feat: add support for client-side prerequisite events #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
requested review from
kinyoklion and
keelerm84
and removed request for
kinyoklion
cwaldren-ld
changed the title
cwaldren-ld
commented
Oct 18, 2024
| @@ -67,6 +67,10 @@ type FlagState struct { | |||
| // OmitDetails is true if, based on the options passed to AllFlagsState and the flag state, some of the | |||
| // metadata can be left out of the JSON representation. | |||
| OmitDetails bool | |||
|
|
|||
There was a problem hiding this comment.
This is a new exposed field on the public API, so this PR needs to be a feat.
kinyoklion
approved these changes
Oct 22, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 23, 2024
🤖 I have created a release *beep* *boop* --- ## [7.7.0](v7.6.2...v7.7.0) (2024-10-22) ### Features * add support for client-side prerequisite events ([#201](#201)) ([d9804ec](d9804ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
AllFlagsStateto track prerequisite evaluations.This didn't require modifying the eval module, as it already exposes a
PrerequisiteEventRecorderinterface with the necessary info.The
AllFlagsStatepublic API allows for fetching a flag's details (FlagState) from the top-levelAllFlagsobject. This struct now has prerequisite information exposed.Additionally when the
AllFlagsis marshaled to JSON, it will now contain the prerequisite info for each flag.