ci: fix sed command in check-go-versions.yml #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/fix-go-version-workflow
branch
from
da3b59a to
9e8bae7
Compare
cwaldren-ld
force-pushed
the
cw/fix-go-version-workflow
branch
from
9e8bae7 to
1026c6a
Compare
cwaldren-ld
commented
Mar 26, 2024
| @@ -25,8 +25,8 @@ jobs: | |||
| - name: Parse officially supported Go versions | |||
| id: parse | |||
| run: | | |||
| echo "latest=${{ fromJSON(env.fetch-api-data)[0].latest }}" >> $GITHUB_OUTPUT | |||
| echo "penultimate=${{ fromJSON(env.fetch-api-data)[1].latest }}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Instead of using the full Go versions (like 1.22.1), just grab only the "cycle" (1.22). This is what we want in the docs and in the go.mod.
kinyoklion
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See created PR: #127