refactor: remove unused baseURI variables related to ServiceEndpoints #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Mar 5, 2024
| @@ -48,11 +48,8 @@ func getCustom(serviceEndpoints interfaces.ServiceEndpoints, serviceType Service | |||
| } | |||
|
|
|||
| // IsCustom returns true if the service endpoint has been overridden with a non-default value. | |||
| func IsCustom(serviceEndpoints interfaces.ServiceEndpoints, serviceType ServiceType, overrideValue string) bool { | |||
There was a problem hiding this comment.
overrideValue was always "".
cwaldren-ld
force-pushed
the
cw/sc-234826/endpoint-refactor
branch
from
46d3225 to
cbf7edb
Compare
cwaldren-ld
force-pushed
the
cw/sc-234826/endpoint-refactor
branch
from
cbf7edb to
7a7aa61
Compare
keelerm84
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #103, I noticed that some of the code related to
ServiceEndpointsseems to be using abaseURIvariable that isn't actually set anywhere.I've removed those internal
baseURIvariables in the streaming/polling/event builders, which allowed me to remove an unusedoverrideValueparameter from some of the ServiceEndpoint utility functions.