Skip to content

Commit

Permalink
undo some accidental renames from Close to Finish
Browse files Browse the repository at this point in the history
  • Loading branch information
cwaldren-ld committed Nov 21, 2024
1 parent 8f79a83 commit fd536f3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion interfaces/client_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ type LDClientEvents interface {
// LDClientInterface defines the basic SDK client operations implemented by LDClient.
//
// This includes all methods for evaluating a feature flag or generating analytics events, as defined by
// LDEvaluations and LDEvents. It does not include general control operations like Flush(), Finish(), or
// LDEvaluations and LDEvents. It does not include general control operations like Flush(), Close(), or
// GetDataSourceStatusProvider().
type LDClientInterface interface {
LDClientEvaluations
Expand Down
2 changes: 1 addition & 1 deletion internal/broadcasters.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
//
// The standard pattern is that AddListener returns a new receive-only channel; RemoveListener unsubscribes
// that channel, and closes the sending end of it; Broadcast sends a value to all of the subscribed channels
// (if any); and Finish unsubscribes and closes all existing channels.
// (if any); and Close unsubscribes and closes all existing channels.

// Arbitrary buffer size to make it less likely that we'll block when broadcasting to channels. It is still
// the consumer's responsibility to make sure they're reading the channel.
Expand Down
2 changes: 1 addition & 1 deletion internal/datasource/streaming_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan<
if !ok {
// COVERAGE: stream.Events is only closed if the EventSource has been closed. However, that
// only happens when we have received from sp.halt, in which case we return immediately
// after calling stream.Finish(), terminating the for loop-- so we should not actually reach
// after calling stream.Close(), terminating the for loop-- so we should not actually reach
// this point. Still, in case the channel is somehow closed unexpectedly, we do want to
// terminate the loop.
return
Expand Down
2 changes: 1 addition & 1 deletion internal/datasourcev2/streaming_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan<
if !ok {
// COVERAGE: stream.Events is only closed if the EventSource has been closed. However, that
// only happens when we have received from sp.halt, in which case we return immediately
// after calling stream.Finish(), terminating the for loop-- so we should not actually reach
// after calling stream.Close(), terminating the for loop-- so we should not actually reach
// this point. Still, in case the channel is somehow closed unexpectedly, we do want to
// terminate the loop.
return
Expand Down

0 comments on commit fd536f3

Please sign in to comment.