Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Casey Waldren <[email protected]>
  • Loading branch information
louis-launchdarkly and cwaldren-ld authored May 10, 2024
1 parent b724384 commit 2a112bf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ldclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ import (
// Version is the SDK version.
const Version = internal.SDKVersion

// HighWaitForSeconds is the initialization wait time threshold that we will log a warning message
const HighWaitForSeconds = 60
// highWaitForSeconds is the initialization wait time threshold that we will log a warning message
const highWaitForSeconds = 60

const (
boolVarFuncName = "LDClient.BoolVariation"
Expand Down Expand Up @@ -333,8 +333,8 @@ func MakeCustomClient(sdkKey string, config Config, waitFor time.Duration) (*LDC

// If you use a long duration and wait for the timeout, then any network delays will cause
// your application to wait a long time before continuing execution.
if waitFor.Seconds() > HighWaitForSeconds {
loggers.Warnf("Make Client was called with a timeout greater than %d. "+
if waitFor.Seconds() > highWaitForSeconds {
loggers.Warnf("Client was created was with a timeout greater than %d. "+
"We recommend a timeout of less than %d seconds", HighWaitForSeconds)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / ldotel Linux, Go 1.22

undefined: HighWaitForSeconds (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / ldotel Linux, Go 1.22

undefined: HighWaitForSeconds) (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / ldotel Linux, Go 1.21

undefined: HighWaitForSeconds (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / ldotel Linux, Go 1.21

undefined: HighWaitForSeconds) (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Windows, Go 1.22

undefined: HighWaitForSeconds

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Windows, Go 1.21

undefined: HighWaitForSeconds

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.21 / Benchmarks

undefined: HighWaitForSeconds

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.21 / Unit Tests and Coverage

undefined: HighWaitForSeconds (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.21 / Unit Tests and Coverage

undefined: HighWaitForSeconds) (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.22 / Benchmarks

undefined: HighWaitForSeconds

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.22 / Unit Tests and Coverage

undefined: HighWaitForSeconds (typecheck)

Check failure on line 338 in ldclient.go

View workflow job for this annotation

GitHub Actions / Linux, Go 1.22 / Unit Tests and Coverage

undefined: HighWaitForSeconds) (typecheck)
}

Expand Down

0 comments on commit 2a112bf

Please sign in to comment.