This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
fix: telemetry activity source should use its own version #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
approved these changes
Apr 23, 2024
kinyoklion
approved these changes
Apr 23, 2024
|
Noticed the unit tests for Telemetry package aren't actually running, so debugging why that is. |
|
Looks like we had to include the xunit.visualstudio runner as a dependency. Why this didn't complain louder, I do not know. |
cwaldren-ld
pushed a commit
that referenced
this pull request
Apr 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.1](telemetry-0.2.0...telemetry-0.2.1) (2024-04-23) ### Bug Fixes * telemetry activity source should use its own version ([#207](#207)) ([82dd679](82dd679)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the Telemetry package has a reference to
LaunchDarkly.Sdk.Internal, to retrieve that component's version number.The version is then passed into the
ActivitySource. I think this made sense when theTracingHookwas part of the SDK package.Now that it is its own distinct component, with its own version number, I think it's most correct to pass its own info (assembly name and version).
I think it makes sense to have the SDK's version number somehow be reported in telemetry as well. Not sure how that would work - perhaps the SDK would have its own activity source, or we could add it as an extra attribute? I don't know the conventions well enough.