Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

ci: Adds LaunchDarkly.ServerSdk.Telemetry package and associated GA reorganization #195

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

tanderson-ld
Copy link
Contributor

Adds LaunchDarkly.ServerSdk.Telemetry package and associated reorganization of Github Actions and Release Please configuration to support releasing multiple packages from this repository.

@tanderson-ld tanderson-ld requested a review from a team April 19, 2024 19:54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: this has been replaced by the full-release action.

@@ -20,7 +20,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\src\LaunchDarkly.ServerSdk\LaunchDarkly.ServerSdk.csproj" />
<ProjectReference Include="..\src\LaunchDarkly.ServerSdk.csproj" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Intentionally removed stuttery folder structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During discussion with Ryan, we talked about reorganizing the directories to match the namespacing. I thought about this more and chose not to due to a mixture of total time this story is taking and fear that release-please won't like the overlapping namespacing (I haven't dealt with release-please directory exclusions and don't really want to go down that rabbit hole at this moment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: This is the test project for the ServerSdk, so no telemetry deps should appear here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Copy of ServerSdk csproj but then tweaked to be for telemetry. Please double check I didn't miss anything obvious here.

@tanderson-ld tanderson-ld merged commit 98fc994 into feat/otel Apr 22, 2024
7 checks passed
@tanderson-ld tanderson-ld deleted the ta/sc-236788/otel-package-squashed branch April 22, 2024 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants