-
Notifications
You must be signed in to change notification settings - Fork 25
ci: Adds LaunchDarkly.ServerSdk.Telemetry package and associated GA reorganization #195
Conversation
…entation for recording evaluation events using the System.Diagnostic.Activity API.
.github/workflows/publish.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: this has been replaced by the full-release action.
@@ -20,7 +20,7 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<ProjectReference Include="..\src\LaunchDarkly.ServerSdk\LaunchDarkly.ServerSdk.csproj" /> | |||
<ProjectReference Include="..\src\LaunchDarkly.ServerSdk.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Intentionally removed stuttery folder structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During discussion with Ryan, we talked about reorganizing the directories to match the namespacing. I thought about this more and chose not to due to a mixture of total time this story is taking and fear that release-please won't like the overlapping namespacing (I haven't dealt with release-please directory exclusions and don't really want to go down that rabbit hole at this moment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: This is the test project for the ServerSdk, so no telemetry deps should appear here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Copy of ServerSdk csproj but then tweaked to be for telemetry. Please double check I didn't miss anything obvious here.
Adds LaunchDarkly.ServerSdk.Telemetry package and associated reorganization of Github Actions and Release Please configuration to support releasing multiple packages from this repository.