Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename model.id and provider.id to name #61

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Dec 9, 2024

Renames the model.id and provider.id fields in AI Config JSON protocol to name.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review December 9, 2024 18:54
@cwaldren-ld cwaldren-ld requested a review from a team as a code owner December 9, 2024 18:54
Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should SetModelProviderId (line 178) and SetModelId (line 167) keep their current names? I was expecting them to change but may not be understanding the proposed updates correctly.

@cwaldren-ld
Copy link
Contributor Author

@mmrj good eye, you are correct. I've updated.

@cwaldren-ld cwaldren-ld merged commit a0d0705 into main Dec 10, 2024
11 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sdk-961-id-to-name branch December 10, 2024 19:45
cwaldren-ld pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](LaunchDarkly.ServerSdk.Ai-v0.3.2...LaunchDarkly.ServerSdk.Ai-v0.4.0)
(2024-12-10)


### ⚠ BREAKING CHANGES

* rename model.id and provider.id to name
([#61](#61))
* rename _ldMeta.versionKey to variationKey
([#62](#62))

### Code Refactoring

* rename _ldMeta.versionKey to variationKey
([#62](#62))
([3f7089d](3f7089d))
* rename model.id and provider.id to name
([#61](#61))
([a0d0705](a0d0705))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants