Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Use LeakSanitizer to catch future memory leaks #472

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Nov 22, 2024

Description

Follow-up to #471. The address sanitizer should catch memory leaks, but it needs the configuration, which was missing

https://clang.llvm.org/docs/LeakSanitizer.html

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5
Copy link
Member

simo5 commented Nov 22, 2024

@Jakuje as you are fixing tests, would you mind adding --features standard to kryoptic builds to fix the kryoptic CI as well ?

@Jakuje
Copy link
Contributor Author

Jakuje commented Nov 22, 2024

@Jakuje as you are fixing tests, would you mind adding --features standard to kryoptic builds to fix the kryoptic CI as well ?

I started in #473 simplifying the kryoptic build to use dynamic feature, but we need the standard too, which I forgot on first try. Changed now. But it still does not work. Trying now here only the standard feature.

@simo5
Copy link
Member

simo5 commented Nov 22, 2024

@Jakuje .github/workflows/integration.yml needs the same treatment

@Jakuje
Copy link
Contributor Author

Jakuje commented Nov 22, 2024

@Jakuje .github/workflows/integration.yml needs the same treatment

Added. Missed that one.

@simo5 simo5 merged commit 20bc584 into latchset:main Nov 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants