Fix session count types #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit f1e85af ("Session locking fixes") the session count variables are int. This is wrong since max_sessions is initialized by the token ulMaxSessionCount member so it of type CK_ULONG. Interpreting it as int is wrong since all values >= BIT(31) are interpreted as negative value. Fix this by converting all session counting vars back to CK_ULONG. Fixes: f1e85af ("Session locking fixes") Signed-off-by: Marco Felsch <[email protected]>
|
The bind failure is a known fail, an unrelated. Thanks for the contribution @bith3ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since commit f1e85af ("Session locking fixes") the session count variables are int. This is wrong since max_sessions is initialized by the token ulMaxSessionCount member so it of type CK_ULONG. Interpreting it as int is wrong since all values >= BIT(31) are interpreted as negative value.
Fix this by converting all session counting vars back to CK_ULONG.
Reviewer's checklist:
Any issues marked for closing are addressedThis feature/change has adequate documentation added