fixing Covscan PR target #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to source the correct PR code in PR Cov Scans It is not directly testable as pull_request_target code is only really run after a PR is merged to main (by design). This commit also adds support for a no-covscan label so that PRs can be merged w/o running a covscan and yet having all tragets met and not requiring to override the project policy at merge time Signed-off-by: Simo Sorce <[email protected]>
simo5
added
no-covscan-obsolete-label
|
Merging this in the hope the changes to coverity scan work as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Coverity Scan job that runs on PRs is supposed to pull the PR code when running in the pull_request_target case, but it is sourcing the incorrect ref.
Also The Coverity Scan is blocking, but we do not want to run it when there are no code changes, so add a new no-covscan label that makes the test pass w/o running one of the 4 covscan jobs/day we are allowed.
Checklist
Reviewer's checklist:
Any issues marked for closing are addressed