Address various issues with meson builds #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ueno can you take a look at this one? |
Signed-off-by: Simo Sorce <[email protected]>
- This way test setup runs during meson test and not the compile test - This way it runs only once I tried with add_test_setup() but that would cause the setup programs to be re-executed before each and every test Signed-off-by: Simo Sorce <[email protected]>
This way they get built before the tests are run if not already We mark these binary as not build by default, but that does nothing because mesonbuild/meson#2518 which has been open for only 6+ years now [face-palm.gif] Signed-off-by: Simo Sorce <[email protected]>
Run setup only if needed. Compile only pkcs11 but not all the tests as the main make target Signed-off-by: Simo Sorce <[email protected]>
There are some dependencies between tests that are not explicit. For the moment do not run tests in parallel to avoid spurious failures. Signed-off-by: Simo Sorce <[email protected]>
Restore more ergonomic build failure review Signed-off-by: Simo Sorce <[email protected]>
ueno
approved these changes
Apr 23, 2024
neverpanic
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change to the meson build system regressed some minor things that I am attempting to fix here:
Meson defaults to a ginormous log file with the output of all tests mashed together, this works but makes looking at specific test failures harder.
Checklist
Code modified for featureTest suite updated with negative testsDocumentation updatedReviewer's checklist:
Any issues marked for closing are addressedThis feature/change has adequate documentation addedCoverity Scan has run if needed (code PR) and no new defects were found