Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with pin-source parameter in PKCS#11 URI #384

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

sarroutbi
Copy link
Contributor

@sarroutbi sarroutbi commented Apr 23, 2024

Resolves: #383

Description

Add tests with pin-source parameter in PKCS#11 URI.

Checklist

  • Test suite updated with functionality tests

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@sarroutbi sarroutbi force-pushed the 202404231300-include-pin-source-tests branch 7 times, most recently from eb747a1 to 5afaa21 Compare April 23, 2024 11:49
@sarroutbi sarroutbi marked this pull request as ready for review April 23, 2024 11:54
@sarroutbi
Copy link
Contributor Author

sarroutbi commented Apr 23, 2024

I will increase the test timeouts, as I am seeing longer times than 30 seconds in some tests:

...
 5/33 pkcs11-provider:softhsm / certs            OK              33.85s
 6/33 pkcs11-provider:softokn / basic            OK              36.04s
 7/33 pkcs11-provider:softhsm / pubkey           OK              48.54s
 8/33 pkcs11-provider:softhsm / ecc              OK              70.15s
 9/33 pkcs11-provider:softhsm / edwards          OK              69.19s
10/33 pkcs11-provider:softhsm / basic            OK             133.68s
...
32/33 pkcs11-provider:softokn / uri              OK              66.53s
33/33 pkcs11-provider:softhsm / uri              OK             190.58s

@sarroutbi sarroutbi force-pushed the 202404231300-include-pin-source-tests branch from 5afaa21 to 1167f9e Compare April 23, 2024 12:18
tests/meson.build Outdated Show resolved Hide resolved
@simo5 simo5 added the covscan Triggers Coverity Scanner label Apr 23, 2024
@simo5
Copy link
Member

simo5 commented Apr 23, 2024

(FYI ignore whatever covscan result we get, I am running it only to check it works, but it may fail, I need a datapoint on a real PR to adjust something in it)

@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Apr 23, 2024
@sarroutbi sarroutbi force-pushed the 202404231300-include-pin-source-tests branch 2 times, most recently from af36027 to 55d177e Compare April 23, 2024 13:57
@sarroutbi sarroutbi force-pushed the 202404231300-include-pin-source-tests branch from 55d177e to d3adfb1 Compare April 23, 2024 15:15
@simo5 simo5 added the no-covscan-obsolete-label Do not use this label label Apr 24, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed no-covscan-obsolete-label Do not use this label labels Apr 24, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Apr 24, 2024
@simo5 simo5 merged commit e3c3571 into latchset:main Apr 24, 2024
27 of 30 checks passed
@simo5
Copy link
Member

simo5 commented Apr 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to include PKCS#11 URI containing pin-source
2 participants