Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests/README (adapt to meson) #382

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

sarroutbi
Copy link
Contributor

@sarroutbi sarroutbi commented Apr 23, 2024

Resolves: #381

Description

Fix tests/README file (adapt to meson based compilation)

Checklist

  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@sarroutbi sarroutbi force-pushed the 202404231159-fix-readme branch 3 times, most recently from 9265d93 to f6d470e Compare April 23, 2024 10:09
@sarroutbi sarroutbi marked this pull request as ready for review April 23, 2024 10:13
@sarroutbi sarroutbi force-pushed the 202404231159-fix-readme branch 2 times, most recently from 3b39366 to 5dff063 Compare April 23, 2024 10:49
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language changes please

tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
@sarroutbi sarroutbi force-pushed the 202404231159-fix-readme branch from 5dff063 to 609bb95 Compare April 23, 2024 14:01
@sarroutbi sarroutbi force-pushed the 202404231159-fix-readme branch from 609bb95 to 35dbf74 Compare April 23, 2024 14:08
@sarroutbi sarroutbi requested a review from simo5 April 23, 2024 14:16
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5 simo5 merged commit 57804f2 into latchset:main Apr 23, 2024
24 of 27 checks passed
@simo5
Copy link
Member

simo5 commented Apr 23, 2024

Thanks!

@sarroutbi sarroutbi deleted the 202404231159-fix-readme branch April 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong information in tests/README
2 participants