ci: Switch to macOS 14 on M series chips #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 12 was released in October 21, and since then 13 has been out in October 22, and 14 in September 23. Switch to a more recent Mac operating system since that's likely what users will be running. See [1] for GitHub's list of available shared runners. From the macos-12 label to the macos-14 label, the number of CPU cores stays the same (3), but the CPU architecture switches from x86_64 to arm64. All other parameters stay the same except for RAM, which changes from 14 GB to 7 GB. Since pkcs11-provider is not a memory intensive project, this likely has negligible impact on us. The new CPU architecture can be helpful to identify hardware-specific issues, so is probably a net positive. The M series chips are also typically much faster than the older Intel counterparts. [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Clemens Lang <[email protected]>
|
This is also nice because the macOS-14 run is now actually the first CI step to finish :) |
Jakuje
approved these changes
Apr 11, 2024
IIRC Simo only wanted one. I also think we don't really need to continue supporting older macOS releases for a longer time, plus there's really nothing in pkcs11-provider that would behave in a different way on an older macOS. I don't think there's a lot of added value by testing older macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
macOS 12 was released in October 21, and since then 13 has been out in October 22, and 14 in September 23. Switch to a more recent Mac operating system since that's likely what users will be running.
See [1] for GitHub's list of available shared runners. From the macos-12 label to the macos-14 label, the number of CPU cores stays the same (3), but the CPU architecture switches from x86_64 to arm64. All other parameters stay the same except for RAM, which changes from 14 GB to 7 GB. Since pkcs11-provider is not a memory intensive project, this likely has negligible impact on us. The new CPU architecture can be helpful to identify hardware-specific issues, so is probably a net positive. The M series chips are also typically much faster than the older Intel counterparts.
Checklist
Test suite updated with functionality testsTest suite updated with negative testsDocumentation updatedReviewer's checklist:
Coverity Scan has run if needed (code PR) and no new defects were found