Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run tests also against CentOS 9 (OpenSSL 3.0) #369

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Apr 5, 2024

Description

The Debian is unstable so it is moving quite fast with the OpenSSL versions. Fedora will update from OpenSSL 3.1 to 3.2 in coming month so we will not be able to check the changes keep working with older OpenSSL versions, which is our interest for RHEL9.

Checklist

  • Code modified for feature

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

The SHA1 signatures do not work on EL9

Signed-off-by: Jakub Jelen <[email protected]>
@Jakuje Jakuje force-pushed the centos branch 2 times, most recently from 451eca0 to b5ead28 Compare April 5, 2024 08:21
Jakuje added 2 commits April 5, 2024 10:53
The CentOS 9 does has old valgrind macros that do not work.

Signed-off-by: Jakub Jelen <[email protected]>
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want to change the code to use the system-release file, I do not think it is a deal breaker, it works as is as well.

.github/workflows/build.yml Show resolved Hide resolved
@simo5 simo5 merged commit 1362378 into latchset:main Apr 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants