-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests (libssh, httpd, bind) #358
Conversation
Signed-off-by: Ondrej Moris <[email protected]>
ce8f1f6
to
c252279
Compare
New integration tests results can be found in the checks too (all passes). |
Signed-off-by: Ondrej Moris <[email protected]>
Signed-off-by: Ondrej Moris <[email protected]>
Signed-off-by: Ondrej Moris <[email protected]>
Signed-off-by: Ondrej Moris <[email protected]>
4732395
to
ef4bb48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I am afarid of the time it may take to run this is there are a lot of steps that pull lots of data from the network.
So the integration step took 6 minutes. See this for inspiration: |
I'll take a look how to make it faster, a lot of time is spent on installing F40 packages now. But maybe that can be cached too somehow. |
Se previous comment, you just need to copy that code :-) |
Signed-off-by: Ondrej Moris <[email protected]>
With matrix strategy integration tests workflow only takes ~2 minutes (1:57) now. I tried to add actions/cache on top of that but it had no effect in this case (it looks like dnf step is now running at the same time in all three jobs). |
Awesome thanks, |
This PR adds two new tests (for httpd and bind) and re-factors previously added test for libssh. Tests are intended to run in CI (github actions) but they can be executed on any Fedora (39 and newer) as follows (
GIT_URL
defaults to this repository andGIT_REF
to the main branch):Testing requires bash -e option. Non-zero exit code means failure. Provider debug logs are always printed out at the end (regardless of the result). All three tests uses softhsm token (bind test does so via p11-kit server proxy). Please notice that until Fedora 40 is released both httpd and bind test need to use a specific docker image.