Minor coverity fixes #315
Merged
Minor coverity fixes #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL is in charge of making sure the context is not used when it is freed. Repurpose the lock to only cover parts of the context that can be changed by independent threads after the context creation. Fixes: CID 468683 CID 468679 Signed-off-by: Simo Sorce <[email protected]>
We will always pay the price of a lock, but this is the more robust thing to do for now. Fixes: CID 468681 CID 468678 Signed-off-by: Simo Sorce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are locking related.
There wasn't anything really wrong in the code, because of external guarantees, and some actions were intentional.
However Coverity rightfully complains as from a strict pov the code was not always properly following a consistent use of locking.
This may call for followup PRs to make Coverity happy if this first round is not sufficient.