Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key generation template size and debug log message #283

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix key generation template size and debug log message #283

merged 2 commits into from
Sep 12, 2023

Conversation

fabled
Copy link
Collaborator

@fabled fabled commented Sep 5, 2023

  • Fix EC private key generation template size
  • Fix p11prov_common_gen_init debug log entry

@fabled fabled requested a review from simo5 September 5, 2023 12:46
@simo5
Copy link
Member

simo5 commented Sep 11, 2023

Looks good to me, but DCO check needs to be fixed.

simo5
simo5 requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix DCO check please

@fabled fabled requested a review from simo5 September 12, 2023 07:02
simo5
simo5 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5 simo5 merged commit 30a1e8e into latchset:main Sep 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabled @simo5