forked from open-telemetry/opentelemetry-go
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changed signature of the Span
RecordError, replace EventOption by E…
…rrorOption (open-telemetry#1677) * Change signature of the Span `RecordError, replace EventOption by ErrorOption * Add WithEventOpts, WithErrorStatus * Set status when WithErrorStatus is passed to RecordError Signed-off-by: lastchiliarch <[email protected]>
- Loading branch information
Showing
73 changed files
with
1,897 additions
and
1,763 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: enhancement | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ### Problem Statement | ||
|
|
||
| A clear and concise description of what the problem is. | ||
| Ex. I'm always frustrated when [...] | ||
|
|
||
| ### Proposed Solution | ||
|
|
||
| A clear and concise description of what you want to happen. | ||
|
|
||
| #### Alternatives | ||
|
|
||
| A clear and concise description of any alternative solutions or features you've considered. | ||
|
|
||
| #### Prior Art | ||
|
|
||
| A clear and concise list of any similar and existing solutions from other projects that provide context to possible solutions. | ||
|
|
||
| ### Additional Context | ||
|
|
||
| Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,14 +24,14 @@ jobs: | |
| echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV | ||
| echo "$(go env GOPATH)/bin" >> $GITHUB_PATH | ||
| - name: Module cache | ||
| uses: actions/[email protected].4 | ||
| uses: actions/[email protected].5 | ||
| env: | ||
| cache-name: go-mod-cache | ||
| with: | ||
| path: ~/go/pkg/mod | ||
| key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('**/go.sum') }} | ||
| - name: Tools cache | ||
| uses: actions/[email protected].4 | ||
| uses: actions/[email protected].5 | ||
| env: | ||
| cache-name: go-tools-cache | ||
| with: | ||
|
|
@@ -58,7 +58,7 @@ jobs: | |
| echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV | ||
| echo "$(go env GOPATH)/bin" >> $GITHUB_PATH | ||
| - name: Module cache | ||
| uses: actions/[email protected].4 | ||
| uses: actions/[email protected].5 | ||
| env: | ||
| cache-name: go-mod-cache | ||
| with: | ||
|
|
@@ -81,7 +81,7 @@ jobs: | |
| echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV | ||
| echo "$(go env GOPATH)/bin" >> $GITHUB_PATH | ||
| - name: Module cache | ||
| uses: actions/[email protected].4 | ||
| uses: actions/[email protected].5 | ||
| env: | ||
| cache-name: go-mod-cache | ||
| with: | ||
|
|
@@ -134,7 +134,7 @@ jobs: | |
| echo "$(go env GOPATH)/bin" >> $GITHUB_PATH | ||
| shell: bash | ||
| - name: Module cache | ||
| uses: actions/[email protected].4 | ||
| uses: actions/[email protected].5 | ||
| env: | ||
| cache-name: go-mod-cache | ||
| with: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Default state for all rules | ||
| default: true | ||
|
|
||
| # ul-style | ||
| MD004: false | ||
|
|
||
| # hard-tabs | ||
| MD010: false | ||
|
|
||
| # line-length | ||
| MD013: false | ||
|
|
||
| # no-duplicate-header | ||
| MD024: | ||
| siblings_only: true | ||
|
|
||
| # ol-prefix | ||
| MD029: | ||
| style: ordered | ||
|
|
||
| # no-inline-html | ||
| MD033: false | ||
|
|
||
| # fenced-code-language | ||
| MD040: false | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ You can view and edit the source code by cloning this repository: | |
| git clone https://github.com/open-telemetry/opentelemetry-go.git | ||
| ``` | ||
|
|
||
| Run `make test` to run the tests instead of `go test`. | ||
| Run `make test` to run the tests instead of `go test`. | ||
|
|
||
| There are some generated files checked into the repo. To make sure | ||
| that the generated files are up-to-date, run `make` (or `make | ||
|
|
@@ -43,7 +43,7 @@ To create a new PR, fork the project in GitHub and clone the upstream | |
| repo: | ||
|
|
||
| ```sh | ||
| $ go get -d go.opentelemetry.io/otel | ||
| go get -d go.opentelemetry.io/otel | ||
| ``` | ||
|
|
||
| (This may print some warning about "build constraints exclude all Go | ||
|
|
@@ -53,7 +53,7 @@ This will put the project in `${GOPATH}/src/go.opentelemetry.io/otel`. You | |
| can alternatively use `git` directly with: | ||
|
|
||
| ```sh | ||
| $ git clone https://github.com/open-telemetry/opentelemetry-go | ||
| git clone https://github.com/open-telemetry/opentelemetry-go | ||
| ``` | ||
|
|
||
| (Note that `git clone` is *not* using the `go.opentelemetry.io/otel` name - | ||
|
|
@@ -66,20 +66,20 @@ current working directory. | |
| Enter the newly created directory and add your fork as a new remote: | ||
|
|
||
| ```sh | ||
| $ git remote add <YOUR_FORK> [email protected]:<YOUR_GITHUB_USERNAME>/opentelemetry-go | ||
| git remote add <YOUR_FORK> [email protected]:<YOUR_GITHUB_USERNAME>/opentelemetry-go | ||
| ``` | ||
|
|
||
| Check out a new branch, make modifications, run linters and tests, update | ||
| `CHANGELOG.md`, and push the branch to your fork: | ||
|
|
||
| ```sh | ||
| $ git checkout -b <YOUR_BRANCH_NAME> | ||
| git checkout -b <YOUR_BRANCH_NAME> | ||
| # edit files | ||
| # update changelog | ||
| $ make precommit | ||
| $ git add -p | ||
| $ git commit | ||
| $ git push <YOUR_FORK> <YOUR_BRANCH_NAME> | ||
| make precommit | ||
| git add -p | ||
| git commit | ||
| git push <YOUR_FORK> <YOUR_BRANCH_NAME> | ||
| ``` | ||
|
|
||
| Open a pull request against the main `opentelemetry-go` repo. Be sure to add the pull | ||
|
|
@@ -140,8 +140,8 @@ It is preferable to have contributions follow the idioms of the | |
| language rather than conform to specific API names or argument | ||
| patterns in the spec. | ||
|
|
||
| For a deeper discussion, see: | ||
| https://github.com/open-telemetry/opentelemetry-specification/issues/165 | ||
| For a deeper discussion, see | ||
| [this](https://github.com/open-telemetry/opentelemetry-specification/issues/165). | ||
|
|
||
| ## Style Guide | ||
|
|
||
|
|
||
Oops, something went wrong.