-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MariaDB 11 support #698
MariaDB 11 support #698
Conversation
So how would the maria11.stub actually get into the user's docker-compose.yml file? |
@taylorotwell If you're ok with the approach, I can add the rest of the code? |
It could potentially be kept separate from Maria 10. |
@taylorotwell Made the rest of the changes, tried to keep as much as possible in line with what is already there. |
@tomcoonen don't forget to mark the PR back to ready if you need a review 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docker-compose.yaml (the stubs in this case), I would also use mariadb
instead of mariadb10
/mariadb11
because this is also the host which will configured in the .env
Your normally also only have on database. We also only use the name mysql
for MySQL 8
and not mysql8
.
Co-authored-by: Julius Kiekbusch <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
Since MariaDB 11 differentiates more from MySQL, and to still support v10 I've split them up.
While upgrading an app you might need to switch back, and removing the MariaDB volume is extra work. By naming the volumes differently you have no issues there.