Revert "Fix mariadb services" #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 905ac10.
|
@Jubeki best that you provide as much info on the PR description as needed so Taylor knows why you're making this change. |
|
@driesvints yeah that was the plan. I wanted to finish writing the other PR first. (some problems occurred with the database creation, so I will take look later). I added the needed description now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23 and is a companion to laravel/sail#707.
The introduction of two mariadb versions resulted in unneeded complexity, for selecting, installing and then building the Sail Container. This PR should only be merged, after the new Laravel Sail version is released.