Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remember Me Functionality to Registered User Login #579

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

cvairlis
Copy link
Contributor

Pull Request Description

This pull request introduces support for the "Remember Me" functionality during the registration process in the RegisteredUserController. The changes ensure that users are logged in with the remember parameter based on the form input provided during registration.

Changes Made

  1. Added $request->boolean('remember') in the store method of RegisteredUserController to handle the "Remember Me" option.
  2. Updated tests in RegisteredUserControllerTest:
    • Added a test to verify that the remember option works when set.
    • Added a test to confirm that the login defaults to not remembering the user when the option is not set.

Impact

  • Enhances user experience by allowing users to stay logged in if they choose to do so during registration.
  • Backward-compatible, with no breaking changes introduced.

Testing

  • All existing tests pass.
  • New tests added to ensure the "Remember Me" functionality behaves as expected in both scenarios (enabled and disabled).

@taylorotwell taylorotwell merged commit 047e84e into laravel:1.x Nov 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants