Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Simplifying UpdateUserProfileInformation.php #575

Closed
wants to merge 3 commits into from

Conversation

MrPunyapal
Copy link

@MrPunyapal MrPunyapal commented Nov 1, 2024

This pull request includes changes to the update method in UpdateUserProfileInformation.php to streamline the process of updating user profile information, particularly focusing on email verification.

Improvements to email verification logic:

  • Simplified the email verification logic by removing the updateVerifiedUser method and handling email verification directly within the update method.
  • Updated the condition to check if the email has changed using the isDirty method and set email_verified_at to null if the email is modified and the user must verify their email.
  • Ensured that the email verification notification is sent if the email was changed by using the wasChanged method.

@MrPunyapal MrPunyapal changed the title WIP [1.x] Simplifying UpdateUserProfileInformation.php Nov 1, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@MrPunyapal MrPunyapal deleted the patch-1 branch November 1, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants