Skip to content

Commit

Permalink
fix: remove more php 8.4 deprecation notices
Browse files Browse the repository at this point in the history
  • Loading branch information
lindyhopchris committed Nov 26, 2024
1 parent b0d4fd4 commit 9ba65f3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.2, 8.3]
php: [8.2, 8.3, 8.4]

steps:
- name: Checkout Code
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec

## Unreleased

### Fixed

- Remove deprecation notices on PHP 8.4.

## [3.0.0] - 2024-03-12

### Changed
Expand Down
1 change: 1 addition & 0 deletions phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
failOnWarning="true"
failOnDeprecation="true"
failOnNotice="true"
displayDetailsOnTestsThatTriggerDeprecations="true"
>
<coverage/>
<testsuites>
Expand Down
4 changes: 2 additions & 2 deletions src/TestResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static function cast($response): self
* @param Response $response
* @param string|null $expectedType
*/
public function __construct($response, string $expectedType = null)
public function __construct($response, ?string $expectedType = null)
{
parent::__construct($response);

Expand Down Expand Up @@ -116,7 +116,7 @@ public function getLocation(): ?string
* @param string|null $pointer
* @return Document|mixed
*/
public function jsonApi(string $pointer = null)
public function jsonApi(?string $pointer = null)
{
$document = $this->getDocument();

Expand Down

0 comments on commit 9ba65f3

Please sign in to comment.