Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'danger' method to match bootstrap class #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danswiser
Copy link

There are four "standard" bootstrap alert classes in addition to the other less standard alerts. The four "proper" alert types are success, info, warning and danger. The alert-danger class does not match the ->error() method name like the other methods do. This leads to confusing behavior.

flash($message)->info();      => class="alert alert-info"
flash($message)->success();   => class="alert alert-success"
flash($message)->warning();   => class="alert alert-warning"
flash($message)->danger();   Does not exist
flash($message)->error();      => class="alert alert-danger"

The original ->error() method remains unchanged for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant