Adjust y_offset calculation to reference baseline #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, the extra pixels above the top of the letters should be
baseline - cap_height
notascent - cap_height
sincebaseline
typically refers to the render position of the bottoms of the letters.Also, it looks like we fall back to ascent if the cap_height doesn't exist, but I think it still makes sense to subtract the extra top pixels in this case.
Feel free to let me know if I'm misunderstanding anything here since this is based mostly on my interpretation of the code and general font rendering terminology.
For reference, here are the values for
Consolas
: