-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matpower conversion #26
Conversation
Beginning the process of converting the source data to a matpower like format
Converted the default inputs to a matpower based input
In the data files would you consider something like (note curly braces),
Same goes for Then I think we can avoid the need for, lanl-ansi/PowerModels.jl#305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor suggestion. If the datasets you are using can be made open access (we should discuss the legal details), then I would highly recomend we propose them as an official IEEE PES GMD test set as part of PGLib, https://github.com/power-grid-lib/
test/data/b4gic.m
Outdated
%% branch data | ||
% fbus tbus r x b rateA rateB rateC ratio angle status angmin angmax | ||
mpc.branch = [ | ||
1 3 0.0001 0.004 0 9000.0 0.0 0.0 1 0.0 1 -29.999999999999996 29.999999999999996 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider touching up the output data writer to clean up the -29.99999
values.
Matpower format cleanup
Agreed. This was a more elegant way of handling the data. I have updated the data sets accordingly. And, yes, this reduces the need for lanl-ansi/PowerModels.jl#305 |
This pull request changes the default input format to follow the matpower conventions
@bluejuniper Take a look at the matpower based input files. I removed redundant/unused data fields that were in the json files. If you see something we should preserve, I will add them back in
@ccoffrin If you see something about the matpower input files that looks strange, let me know. But we should be moved away from the json input files now.