fix: discorrectly allowing upgrade plugin to another plugin_id

langgenius · Oct 25, 2024 · cea4cb0 · cea4cb0
1 parent eeadb3e
commit cea4cb0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/service/install_plugin.go b/internal/service/install_plugin.go
@@ -300,6 +300,10 @@ func UpgradePlugin(
 		return entities.NewErrorResponse(-400, "original and new plugin unique identifier are the same")
 	}
 
+	if original_plugin_unique_identifier.PluginID() != new_plugin_unique_identifier.PluginID() {
+		return entities.NewErrorResponse(-400, "original and new plugin id are different")
+	}
+
 	// uninstall the original plugin
 	installation, err := db.GetOne[models.PluginInstallation](
 		db.Equal("tenant_id", tenant_id),