Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oraclevs integration #7333

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

skmishraoracle
Copy link

Description

This transaction integrates Oracle Vector Search with LangChain.js. The integration enables the use of Oracle's advanced vector search capabilities within the LangChain.js framework. The changes are in oraclevs_integration branch.

Key Features

  • Adds support for Oracle Vector Search in LangChain.js.
  • Includes example usage and tests for the integration.

Fixes

Fixes # (issue)

Testing

  • Verified integration with unit tests.
  • Added relevant test cases to ensure proper functionality.

Request

Kindly review the changes and provide feedback. Please let @skmishraoracle know if there are any issues or areas that need improvement.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 9, 2024
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ❌ Failed (Inspect) Dec 9, 2024 9:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 9, 2024 9:21am

@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Dec 9, 2024
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and sorry for the delay!

Seems like a lot of unneeded changes - please revert them and I can give this a proper look

@@ -17,4 +17,4 @@ supportedArchitectures:
- darwin
- linux

yarnPath: .yarn/releases/yarn-3.5.1.cjs
yarnPath: ./.yarn/releases/yarn-3.5.1.cjs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this?

@@ -45,11 +45,8 @@
"@swc/jest": "^0.2.29",
"@tsconfig/recommended": "^1.0.3",
"@types/uuid": "^9",
"@typescript-eslint/eslint-plugin": "^6.12.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these dep changes

@jacoblee93 jacoblee93 added the in progress PRs that are in progress but not ready to merge label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features in progress PRs that are in progress but not ready to merge size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants