community: add include_labels option to ConfluenceLoader #28259
+77
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nakamasato
changed the title
nakamasato
force-pushed
the
add-include-labels-option-to-confluence-loaders
branch
from
08a12d8
to
f3dffce
Compare
nakamasato
commented
Nov 21, 2024
| metadata = { | ||
| "title": page["title"], | ||
| "id": page["id"], | ||
| "source": self.base_url.strip("/") + page["_links"]["webui"], | ||
| **({"labels": labels} if include_labels else {}), |
There was a problem hiding this comment.
set labels key only when include_labels is set to true
Comment on lines
+596
to
+601
| labels = [ | ||
| label["name"] | ||
| for label in page.get("metadata", {}) | ||
| .get("labels", {}) | ||
| .get("results", []) | ||
| ] |
There was a problem hiding this comment.
dosubot
bot
added
size:M
nakamasato
commented
Nov 21, 2024
Comment on lines
+339
to
+345
| expand = ",".join( | ||
| [ | ||
| content_format.value, | ||
| "version", | ||
| *(["metadata.labels"] if include_labels else []), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
expand is a comma-separated query parameter. originally hardcoded as f"{content_format.value},version".
I made a variable so we can add more option if necessary in the future as expand parameter supports a lot more values.
(ref)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enable
ConfluenceLoaderto include labels withinclude_labelsoption (falseby default for backward compatibility). and the labels are set tometadatain theDocument. e.g.{"labels": ["l1", "l2"]}Notes
Confluence API supports to get labels by providing
metadata.labelstoexpandquery parameterAll of the following functions support
expandin the same way:Issue:
No issue related to this PR.
Dependencies:
No changes.
Twitter handle:
@gymnstcs
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/