fix: use self.embeddings.aembed_* in async methods #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liunux4odoo I tested your PR branch on one of my projects, and it fixed our issue. Thanks! This PR is needed to not break our async data pipelines - I am quite surprised this was an issue at all... @efriis, @eyurtsev, @pprados Can some of the maintainers please review this PR? |
Glad to see this helps. |
efriis
approved these changes
Aug 28, 2024
|
So strange the tests failed, I cannot check what's wrong. |
eyurtsev
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using sync methods of embeddings in PGVector async methods harms performance.