Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy button doesn't work on Safari #21

Closed
abey79 opened this issue Nov 23, 2023 · 2 comments · Fixed by emilk/egui#3621
Closed

Copy button doesn't work on Safari #21

abey79 opened this issue Nov 23, 2023 · 2 comments · Fixed by emilk/egui#3621

Comments

@abey79
Copy link
Contributor

abey79 commented Nov 23, 2023

Safari has a marked tendency of rejecting copy operations that it can't link to user action. For this reason, most copy operations used to fail on Safari with egui/wasm. This was recently fixed in egui 0.24 (emilk/egui#3513), and now copying from code blocks works when selecting text and copy. However it still fails when using the copy button.

Here is a dev build of Rerun based on egui 0.24 where select-and-copy works on Safari, but not the copy button:

https://demo.rerun.io/pr/4111/examples/structure_from_motion/

One must scroll down the description view to reach a code block:

image

Clicking the "Copy" button fails with this error:

image

For reference, this is another dev build that is based on egui 0.23 and where all forms of copying fail:

https://demo.rerun.io/pr/4324/examples/structure_from_motion/
@abey79 abey79 mentioned this issue Nov 23, 2023
Merged
4 tasks
@emilk
Copy link
Contributor

emilk commented Nov 24, 2023

The problem is in eframe: emilk/egui#3513 fixed copy/cut when using keyboard shortcuts, but not when using the mouse buttons. I can make a patch release to fix it.

@emilk emilk mentioned this issue Nov 24, 2023
Merged
emilk added a commit to emilk/egui that referenced this issue Nov 24, 2023
@emilk
Fix click-to-copy on Safari (#3621)
0d24a3a 
* Closes lampsitter/egui_commonmark#21

Follow-up to #3513

Safari only allows access to the clipboard as response to user action,
so we need to take an extra logic step right in the event handler.
@abey79
Copy link
Contributor Author

abey79 commented Nov 24, 2023

Fixed by emilk/egui#3621

@abey79 abey79 closed this as completed Nov 24, 2023
emilk pushed a commit to rerun-io/rerun that referenced this issue Dec 1, 2023
@abey79
Remove the "can't copy/cut on Safari" warning from the Getting Starte…
275639c 
…d guides (#4300)

### What

egui 0.24 will fix the bug where coping from Safari was impossible:
- emilk/egui#3513

This PR removes the related warnings in the in-app Getting Started
guides.

- May be blocked by
lampsitter/egui_commonmark#21??
- Blocked by #4111
- Fixes #4292

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4300) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4300)
- [Docs
preview](https://rerun.io/preview/0a0e58f6c169798c01d1932ecec3fb51cfe6360e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0a0e58f6c169798c01d1932ecec3fb51cfe6360e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix click-to-copy on Safari emilk/egui
2 participants
@emilk @abey79