Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Integrate lnschema-core into lamindb #2309

Merged
merged 31 commits into from
Jan 2, 2025
Merged

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Dec 31, 2024

lnschema-core is now integrated into lamindb and will enable better code architecture and project organization.

The present PR merely performs the integration without re-organizing code.

Note that while the new Django app is called lamindb instead of lnschema_core, we still refer to the schema as the "core" schema; mostly so that we can make this migration without making any changes to the hub.

The PR requires renaming tables in the instance SQL databases. They're now prefixed with lamindb_ instead of lnschema_core_. The change is automated and requires mere confirmation in a dialogue from the user upon connecting to an instance. It has already been performed for these instances:

  • laminlabs/lamindata
  • laminlabs/lamin-site-assets
  • laminlabs/lamin-dev
  • laminlabs/arrayloader-benchmarks

Needs:

Addresses:

Materials:

@falexwolf falexwolf changed the title 🚚 Move files from lnschema-core to here 🏗️ Integrate lnschema-core into lamindb Dec 31, 2024
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 87.60108% with 46 lines in your changes missing coverage. Please review.

Project coverage is 92.36%. Comparing base (2a17099) to head (60975c3).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/base/fields.py 77.35% 24 Missing ⚠️
lamindb/base/ids.py 63.33% 11 Missing ⚠️
lamindb/base/mocks.py 0.00% 10 Missing ⚠️
lamindb/base/users.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
- Coverage   92.82%   92.36%   -0.46%     
==========================================
  Files          55       81      +26     
  Lines        7202     8553    +1351     
==========================================
+ Hits         6685     7900    +1215     
- Misses        517      653     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2025

@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 01:25 Inactive
@falexwolf falexwolf merged commit a846868 into main Jan 2, 2025
15 of 17 checks passed
@falexwolf falexwolf deleted the integrate-lnschema-core branch January 2, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant