-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Integrate lnschema-core
into lamindb
#2309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
🚚 Move files from lnschema-core to here
🏗️ Integrate Dec 31, 2024
lnschema-core
into lamindb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
- Coverage 92.82% 92.36% -0.46%
==========================================
Files 55 81 +26
Lines 7202 8553 +1351
==========================================
+ Hits 6685 7900 +1215
- Misses 517 653 +136 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lnschema-core
is now integrated intolamindb
and will enable better code architecture and project organization.The present PR merely performs the integration without re-organizing code.
Note that while the new Django app is called
lamindb
instead oflnschema_core
, we still refer to the schema as the"core"
schema; mostly so that we can make this migration without making any changes to the hub.The PR requires renaming tables in the instance SQL databases. They're now prefixed with
lamindb_
instead oflnschema_core_
. The change is automated and requires mere confirmation in a dialogue from the user upon connecting to an instance. It has already been performed for these instances:laminlabs/lamindata
laminlabs/lamin-site-assets
laminlabs/lamin-dev
laminlabs/arrayloader-benchmarks
Needs:
lnschema-core
intolamindb
lamindb-setup#921lnschema-core
intolamindb
bionty#177lnschema-core
intolamindb
wetlab#89lnschema-core
intolamindb
ourprojects#7lnschema-core
intolamindb
lamin-cli#100lnschema-core
intolamindb
clinicore#16Addresses:
Materials: