Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 Cleaner API #792

Merged
merged 37 commits into from
Jul 15, 2024
Merged

🚸 Cleaner API #792

merged 37 commits into from
Jul 15, 2024

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jul 10, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

🚀 Deployed on https://66952b09296a3f2a04945439--lamindb-setup-htry.netlify.app

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (d7c5c21) to head (a3e6d9b).

Files Patch % Lines
lamindb_setup/core/_private_django_api.py 79.48% 8 Missing ⚠️
lamindb_setup/core/hashing.py 86.36% 3 Missing ⚠️
lamindb_setup/core/_settings.py 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   82.33%   81.67%   -0.67%     
==========================================
  Files          41       42       +1     
  Lines        3119     3192      +73     
==========================================
+ Hits         2568     2607      +39     
- Misses        551      585      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 06:38 Inactive
@falexwolf falexwolf changed the title ♻️ Fix clean up Django ♻️ Catch DoesNotExist exception Jul 10, 2024
@falexwolf falexwolf closed this Jul 10, 2024
@falexwolf falexwolf reopened this Jul 10, 2024
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 14:57 Inactive
@falexwolf falexwolf changed the title ♻️ Catch DoesNotExist exception 🚸 Cleaner API Jul 12, 2024
@github-actions github-actions bot temporarily deployed to pull request July 12, 2024 15:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 13, 2024 10:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2024 11:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2024 12:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2024 13:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2024 13:58 Inactive
@falexwolf falexwolf mentioned this pull request Jul 15, 2024
Merged
@falexwolf falexwolf merged commit 99d145d into main Jul 15, 2024
6 of 7 checks passed
@falexwolf falexwolf deleted the cleanupdjango branch July 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@falexwolf