Refactor and allow manual release #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chaichontat Sriworarat <[email protected]>
Signed-off-by: Chaichontat Sriworarat <[email protected]>
Signed-off-by: Chaichontat Sriworarat <[email protected]>
|
The refactor looks great! I just don't get why you want to rely on GitHub to create the release notes as explained on Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor release into its own file and add
--no-releaseoption.I rely on GitHub to generate the release notes. To use that, I need to already have a tag of the new version which this package also performs the same thing. I need to bypass that and trigger this once the release notes are edited.
Signed-off-by: Chaichontat Sriworarat [email protected]