Add return type hint to ViewModel::getIterator() #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Thanks @funcoder 👍
Really, this should be Traversable<int, ModelInterface> to fit with the return type of IteratorAggregate - when we eventually get return types added in 3.0, This will receive Traversable as its native return type.
Also, can you please update and target the latest minor 2.31.x. Your change is not a BC break so it can be released in a minor.
|
I should also mention that to keep psalm happy here, you'll need to annotate |
|
🙄 Github interface confused me with the branches xD I hope I got everything the way you wanted it to be, @gsteel ? |
This is to satisfy static code analytic tools like PHPStan and Psalm. Resolves #73 Signed-off-by: func0der <[email protected]>
gsteel
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to satisfy static code analytic tools like PHPStan and Psalm.
Resolves #73 and also helps with #56