-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove id check when checking for started session #98
base: 2.23.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas Müller <[email protected]>
@froschdesign @gsteel There are two tests failing now ( I dont unserstand why PHP's page states
|
Closing the session persists the session data for the next request, it doesn't kill the session; There is still an active session once it has been written to storage. To kill the active session, it must be destroyed with |
Signed-off-by: Thomas Müller <[email protected]>
Signed-off-by: Thomas Müller <[email protected]>
Signed-off-by: Thomas Müller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests that now emit deprecations on 8.4 can be silenced by annotating the test with #[IgnoreDeprecations]
Signed-off-by: Thomas Müller <[email protected]>
Signed-off-by: Thomas Müller <[email protected]>
Fixes #97
Description
In Release 2.22.0 the check for the Constant SID was removed. This lead to the error that the Session could not be started when a session ID was set.