Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixed as array shape #244

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add mixed as array shape #244

merged 1 commit into from
Oct 22, 2024

Conversation

grizzm0
Copy link
Contributor

@grizzm0 grizzm0 commented Oct 21, 2024

Psalm treats array as array<mixed> but PHPStan on level 6 and above requires a shape on the array and gives error when importing ServiceManagerConfiguration.

Signed-off-by: Kristofer Karlsson <[email protected]>
@gsteel gsteel changed the base branch from 4.3.x to 4.2.x October 22, 2024 13:29
@gsteel gsteel self-assigned this Oct 22, 2024
@gsteel gsteel added this to the 4.2.1 milestone Oct 22, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grizzm0 LGTM 👍

@gsteel gsteel merged commit e18a454 into laminas:4.2.x Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants