Merge pull request #36 from gsteel/fix/test-provider-generates-valid-…

…numbers Ensure `invalidPhoneNumberProvider` does not yield valid numbers
laminas · Jul 1, 2024 · 34a5938 · 34a5938
2 parents 21d87e0 + 3100343
commit 34a5938
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/test/NumberGeneratorTrait.php b/test/NumberGeneratorTrait.php
@@ -98,14 +98,29 @@ public static function validPhoneNumberProvider(): Generator
      */
     public static function invalidPhoneNumberProvider(): Generator
     {
-        $util = PhoneNumberUtil::getInstance();
+        $util      = PhoneNumberUtil::getInstance();
+        $shortInfo = ShortNumberInfo::getInstance();
+
         /** @var list<non-empty-string> $regions */
         $regions = $util->getSupportedRegions();
         foreach ($regions as $country) {
             $number = $util->getInvalidExampleNumber($country);
             if (! $number) {
                 continue;
             }
+
+            if (
+                $util->isValidNumber($number)
+                ||
+                $util->isValidNumberForRegion($number, $country)
+                ||
+                $shortInfo->isValidShortNumber($number)
+                ||
+                $shortInfo->isValidShortNumberForRegion($number, $country)
+            ) {
+                continue;
+            }
+
             $national = $number->getNationalNumber();
             assert(is_string($national));