Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit/phpunit:^10.5.38, laminas/laminas-coding-standard:^3.0, Apply… #93

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Dec 4, 2024

No description provided.

@fezfez fezfez changed the base branch from 2.22.x to 2.21.x December 4, 2024 10:46
@fezfez fezfez changed the base branch from 2.21.x to 2.22.x December 4, 2024 10:46
… phpunit attribute migration

Signed-off-by: fezfez <[email protected]>

clean

Signed-off-by: fezfez <[email protected]>

clean
@fezfez
Copy link
Contributor Author

fezfez commented Dec 4, 2024

@gsteel this should be good to go

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for all your work @fezfez

There's a comment on one test case that you can address if you like

test/Client/UseCaseTest.php Outdated Show resolved Hide resolved
test/Client/UseCaseTest.php Outdated Show resolved Hide resolved
@gsteel gsteel added this to the 2.22.0 milestone Dec 4, 2024
@gsteel gsteel added Enhancement QA Quality assurance tasks such as static analysis improvements labels Dec 4, 2024
fezfez and others added 3 commits December 4, 2024 12:50
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
Signed-off-by: fezfez <[email protected]>
@fezfez
Copy link
Contributor Author

fezfez commented Dec 4, 2024

@gsteel done

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @fezfez :)

@gsteel gsteel self-assigned this Dec 4, 2024
@gsteel gsteel merged commit 2e6de66 into laminas:2.22.x Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants