Refactor RealPath

[ramchale]

Q	A
Documentation	yes
Bugfix	no
BC Break	yes
New Feature	no
RFC	no
QA	no

Description

Refactor RealPath for #177

[gsteel]

Thanks @ramchale, but, we still need to "make up" the real path for non-existent files when appropriate

[ramchale]

Thanks @ramchale, but, we still need to "make up" the real path for non-existent files when appropriate

🤦 sorry. Not my best work. I've reworked some of the tests to better cover that with the return value changes.
I've added a test that should check whether the statement about BSD is true, but don't have access to a BSD machine to check and the docker support attempts seem to have petered out.

[gsteel]

Thank you @ramchale - this is looking much better - could we improve the test testExistingFileReturnsRealPath with a data provider along the lines of

[
   __DIR__ . '/_files/foo/../bar/../file.1',
   __DIR__ . '/_files/././file.1',
   __DIR__ . '///_files///file.1',
   // etc…
]

[ramchale]

Thanks @gsteel . I've added those.
__DIR__ . '/_files/foo/../bar/../file.1' is invalid, but seemed like the sort of edge-case that might come up, so I've dropped it in it's own test.
Once you're happy with the changes, is there any issue with me squashing this before it's merged to cut down on some of the undoing of changes in the commit history?

[gsteel]

Thanks again @ramchale - Great improvement

Let me know when you're done squashing and I'll merge 👍

[ramchale]

@gsteel Thanks. Should be ready now

[gsteel]

Thanks!