Add PHP 8.4 support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds PHP 8.4 to the PHP constraint list Signed-off-by: Matthew Weier O'Phinney <[email protected]>
This has been supported since PHP 7.3, and helps improve readability Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Adds 8.4 to PHP constraints - Bumps PHPUnit version slightly to pick up PHP 8.4-compatible version Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
I'm able to resolve the phpcs issues. However, the PHP 8.4 ones appear to be due to having a version of composer that is outdated on CI; I'm unable to reproduce locally when I run the |
|
The phpcs issues here I cannot reproduce locally, either (I fixed different issues reported when I ran it). Will try running with PHP 8.1 to see if that demonstrates the issue. |
|
Cannot reproduce the phpcs issues locally either. |
|
LCS 3.0 is working OK in CI - Only a few pointless param/return types to fix. Can you just bump it to 3.0 to see if the problem is fixed? |
|
Also, psalm won't install on 8.4 so |
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description