Fix duplicated execute functions #19
Open
+160
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoGiachetta
requested review from
edg-l,
igaray,
azteca1998,
fmoletta and
pefontana
as code owners
|
@FrancoGiachetta can you resolve the conflicts on this PR? |
|
✅ Code is now correctly formatted. |
JulianGCalderon
requested changes
Jul 8, 2024
|
Changes where done. |
JulianGCalderon
approved these changes
Jul 10, 2024
| @@ -279,7 +117,8 @@ fn calculate_class_info_for_testing(contract_class: ContractClass) -> ClassInfo | |||
| ClassInfo::new(&contract_class, sierra_program_length, 100).unwrap() | |||
| } | |||
|
|
|||
| pub fn execute_tx_configurable_with_state( | |||
| /// Rxecutes a given transaction returns the execution result | |||
There was a problem hiding this comment.
Suggested change
| /// Rxecutes a given transaction returns the execution result | |
| /// Executes a given transaction and returns the execution result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to check functions execute_tx_configurable and excute_tx, which are doing the same thing. To solve this, execute_tx was removed.