feat(levm): error handling ef_tests (Part 1) #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to levm/ef-tests-error-handling
JereSalo
changed the title
maximopalopoli
approved these changes
Nov 28, 2024
| @@ -72,31 +72,33 @@ pub fn prepare_vm_for_tx(vector: &TestVector, test: &EFTest) -> Result<VM, EFTes | |||
| store: initial_state.database().unwrap().clone(), | |||
| block_hash, | |||
| }); | |||
|
|
|||
| let tx = test.transactions.get(vector).unwrap(); | |||
There was a problem hiding this comment.
Here instead of using .unwrap() you can return an EFTestRunnerError
crates/vm/levm/src/constants.rs
Outdated
| // Storage constants | ||
| pub const COLD_STORAGE_ACCESS_COST: U256 = U256([2100, 0, 0, 0]); | ||
| pub const WARM_ADDRESS_ACCESS_COST: U256 = U256([100, 0, 0, 0]); | ||
| pub const BALANCE_COLD_ADDRESS_ACCESS_COST: U256 = U256([2600, 0, 0, 0]); |
There was a problem hiding this comment.
This cost constants should be in gas_cost.rs, since they are mainly used in that file
There was a problem hiding this comment.
I ended up removing them cause they were not used.
8981d83
crates/vm/levm/src/vm.rs
Outdated
| } | ||
|
|
||
| // Should revert this? | ||
| // sender_account.info.balance -= self.call_frames.first().ok_or(VMError::FatalUnwrap)?.msg_value; |
There was a problem hiding this comment.
I know that comment is not yours, but if it is not necessary we can remove it
There was a problem hiding this comment.
I removed it. I think that in my next PR I'm going to remove revert_create() function anyways.
c9b747f
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Add some other fields to levm's environment: Max priority fee per gas, max fee per gas, block gas limit, max fee per blob gas.
Refactors
tx_blob_hashesandop_blobhash. I realized this opcode wasn't pushing 0 to the stack if no blobhash was found.Make
execute()propagate interal errorsPartially implements validation errors. Partially because for them to be fully implemented I have to make changes like gas consumption logic and that would be too much for this PR.
The amount of tests that passed is pretty similar to the ones that are passing in
main, only a few more are passing. This PR only doesn't fix all execution errors, for this to be fixed I have to make a lot more changes and it would transform itself into a very big PR.Closes #issue_number