chore(l2): forbid expects #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
requested changes
Nov 27, 2024
There was a problem hiding this comment.
If we run the stack with the following steps:
cd crates/l2cp .env.example .envmake init- do
ctrl-cto stop the server, in order to restart it without some env variables. - Comment some env variables starting with
COMMITTER,L1_WATCHER,PROPOSER... etc make init-l2
It will not throw an error nor a message saying that there are missing variables. We should throw an error message and even stop the execution saying that some config variables are missing.
dsocolobsky
force-pushed
the
l2/forbid-expects
branch
from
750c5d6 to
eba775d
Compare
fborello-lambda
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
LGTM, ready to merge if the CI passes. Just make sure that type SetupResult is a struct. in PR #1290 or in this one.
dsocolobsky
force-pushed
the
l2/forbid-expects
branch
4 times, most recently
from
ef9a27f to
f318cde
Compare
…ge in all submodules.
…e was too complex.
dsocolobsky
force-pushed
the
l2/forbid-expects
branch
from
f318cde to
bfa18a7
Compare
ilitteri
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should not be using
.expect()and use Errors instead.Description
expect_used = "deny"was added toCargo.tomlto throw clippy errors on expects..expect()usage was replaced with errorsCloses #1267