feat(levm): move levm EF tests to cmd/ef_tests dir
#1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to move_levm_ef_tests_to_cmd
ilitteri
changed the title
levm EF tests to cmd dirlevm EF tests to cmd/ef_tests dir
fmoletta
reviewed
Nov 14, 2024
fmoletta
reviewed
Nov 14, 2024
fmoletta
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need
ethereum_rustas a dependency for running the EF tests, specifically for the post-state validation. If we import it inside the cratelevm, we have a circular dependency asethereum_rustalso importslevm.Description
ethereum_rustEF tests tocmd/ef_tests/ethereum_rust.ethereum_rustMakefile targets that run the EF tests according to the previous changelevmEF tests tocmd/ef_tests/levm.ethereum_rustMakefile targets that run the EF tests to skiplevmEF tests run (this will be done in the cratelevm)levmMakefile targets that run the EF tests according to the changes above.