Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set max combination size for check-all-features to speed up CI #1717

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fmoletta
Copy link
Contributor

The workflow Make sure all features work (vm) is already taking close to 50 minutes. As there is no way to partition the workflow into sets of features, this PR aims to fix this problem by setting up a max combination of features to reduce the cases to check.
Follow-up work: Investigate other workflows/ solutions that can allow us to properly partition this workflow

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (95d2c88) to head (60179ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1717   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          98       98           
  Lines       38103    38103           
=======================================
  Hits        36161    36161           
  Misses       1942     1942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.331 ± 0.067 2.290 2.485 1.01 ± 0.04
head big_factorial 2.301 ± 0.051 2.270 2.439 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.302 ± 0.054 2.245 2.442 1.03 ± 0.03
head big_fibonacci 2.237 ± 0.016 2.214 2.272 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.640 ± 0.302 8.342 9.350 1.01 ± 0.04
head blake2s_integration_benchmark 8.593 ± 0.172 8.360 8.755 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.351 ± 0.013 2.332 2.370 1.00
head compare_arrays_200000 2.375 ± 0.050 2.340 2.488 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.458 ± 0.015 1.428 1.478 1.00
head dict_integration_benchmark 1.475 ± 0.019 1.449 1.518 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.326 ± 0.013 1.308 1.343 1.00
head field_arithmetic_get_square_benchmark 1.332 ± 0.024 1.305 1.384 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.594 ± 0.173 8.382 8.780 1.00
head integration_builtins 8.709 ± 0.347 8.338 9.608 1.01 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.657 ± 0.151 8.541 8.967 1.00
head keccak_integration_benchmark 8.836 ± 0.182 8.544 8.978 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.342 ± 0.009 2.331 2.355 1.00
head linear_search 2.370 ± 0.017 2.352 2.394 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.600 ± 0.019 1.574 1.639 1.00
head math_cmp_and_pow_integration_benchmark 1.601 ± 0.024 1.578 1.650 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.467 ± 0.023 1.434 1.511 1.01 ± 0.02
head math_integration_benchmark 1.454 ± 0.020 1.431 1.496 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.285 ± 0.014 1.268 1.304 1.00
head memory_integration_benchmark 1.294 ± 0.019 1.273 1.327 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.638 ± 0.013 1.620 1.657 1.00
head operations_with_data_structures_benchmarks 1.643 ± 0.020 1.621 1.694 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 596.3 ± 5.4 591.1 609.4 1.00 ± 0.01
head pedersen 594.5 ± 2.4 591.7 600.0 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 984.1 ± 12.2 972.5 1012.1 1.00 ± 0.01
head poseidon_integration_benchmark 982.3 ± 5.1 976.4 989.9 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.878 ± 0.004 1.868 1.884 1.00
head secp_integration_benchmark 1.893 ± 0.007 1.880 1.904 1.01 ± 0.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 748.8 ± 3.0 743.5 753.1 1.00 ± 0.01
head set_integration_benchmark 748.7 ± 3.6 743.3 755.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.699 ± 0.060 4.620 4.783 1.00
head uint256_integration_benchmark 4.744 ± 0.153 4.646 5.154 1.01 ± 0.04

@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant