Add unit test for apply_ap_tracking_correction with invalid offset
#1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
fmoletta
approved these changes
Apr 16, 2024
Oppen
approved these changes
Apr 16, 2024
Oppen
reviewed
May 9, 2024
| @@ -14,7 +14,7 @@ use super::hint_utils::{get_integer_from_var_name, insert_value_from_var_name}; | |||
| /// x = ids.x, | |||
| /// ids.bit_length = x.bit_length() | |||
| /// ``` | |||
| pub fn get_felt_bitlenght( | |||
| pub fn get_felt_bitlength( | |||
There was a problem hiding this comment.
Hi @tcoratger. Because this method is public, you'll need to update the changelog, as the rename is a breaking change.
Oppen
requested changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for
apply_ap_tracking_correctionwith invalid offsetDescription
This pull request adds a new unit test for the
apply_ap_tracking_correctionfunction in order to cover the scenario where the offset of the hint AP tracking is invalid. This ensures better test coverage and helps identify potential issues related to AP tracking correction.Checklist