Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SyscallError #1357

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Add SyscallError #1357

merged 6 commits into from
Aug 10, 2023

Conversation

pefontana
Copy link
Collaborator

@pefontana pefontana commented Aug 2, 2023

Add SyscallError

Description

  • Add HintError::SyscallError
  • Use constant str in VirtualMachineError::Hint, so other projects can import the str

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.866 ± 0.018 4.835 4.894 1.00
head big_factorial 4.870 ± 0.010 4.850 4.883 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.089 ± 0.010 4.076 4.105 1.00 ± 0.01
head big_fibonacci 4.072 ± 0.022 4.047 4.107 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.341 ± 0.029 11.294 11.375 1.01 ± 0.00
head blake2s_integration_benchmark 11.218 ± 0.036 11.166 11.290 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.167 ± 0.065 4.129 4.348 1.00 ± 0.02
head compare_arrays_200000 4.153 ± 0.013 4.137 4.178 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.766 ± 0.008 2.754 2.774 1.01 ± 0.00
head dict_integration_benchmark 2.741 ± 0.010 2.721 2.754 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.051 ± 0.015 2.033 2.091 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 2.031 ± 0.006 2.020 2.040 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.181 ± 0.038 11.134 11.269 1.00
head integration_builtins 11.200 ± 0.053 11.161 11.340 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.550 ± 0.048 11.484 11.632 1.01 ± 0.01
head keccak_integration_benchmark 11.475 ± 0.057 11.320 11.527 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.151 ± 0.036 4.108 4.212 1.01 ± 0.01
head linear_search 4.126 ± 0.014 4.099 4.148 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.004 ± 0.010 2.986 3.020 1.00
head math_cmp_and_pow_integration_benchmark 3.040 ± 0.010 3.030 3.067 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.731 ± 0.009 2.722 2.753 1.00 ± 0.00
head math_integration_benchmark 2.719 ± 0.007 2.709 2.730 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.410 ± 0.008 2.397 2.425 1.01 ± 0.01
head memory_integration_benchmark 2.380 ± 0.011 2.366 2.403 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.662 ± 0.010 2.645 2.676 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.645 ± 0.017 2.623 2.671 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 992.3 ± 1.8 989.5 994.5 1.00
head pedersen 996.6 ± 3.3 989.9 1001.5 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.766 ± 0.007 1.756 1.778 1.00
head poseidon_integration_benchmark 1.769 ± 0.010 1.756 1.781 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.259 ± 0.015 3.245 3.299 1.01 ± 0.01
head secp_integration_benchmark 3.234 ± 0.006 3.226 3.244 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.955 ± 0.007 1.945 1.967 1.07 ± 0.01
head set_integration_benchmark 1.827 ± 0.008 1.818 1.845 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.420 ± 0.014 7.409 7.453 1.00
head uint256_integration_benchmark 7.425 ± 0.039 7.378 7.506 1.00 ± 0.01

@pefontana pefontana marked this pull request as ready for review August 8, 2023 17:00
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1357 (3061a12) into main (e763cef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1357   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          93       93           
  Lines       37854    37854           
=======================================
  Hits        36904    36904           
  Misses        950      950           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit c249cd9 Aug 10, 2023
39 checks passed
@Oppen Oppen deleted the syscall-error branch August 10, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants